Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile for development shortcuts #109

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add Makefile for development shortcuts #109

merged 1 commit into from
Aug 17, 2023

Conversation

teroyks
Copy link
Contributor

@teroyks teroyks commented Aug 16, 2023

Resolves #108

Use standard commands (dev, lint, test) for development – reduces the need to check the README for repository-specific commands.

@teroyks teroyks self-assigned this Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #109 (a60ca85) into master (dbeef7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          61       61           
  Lines        1847     1847           
  Branches      311      311           
=======================================
  Hits         1710     1710           
  Misses         70       70           
  Partials       67       67           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teroyks teroyks marked this pull request as ready for review August 16, 2023 11:55
@teroyks
Copy link
Contributor Author

teroyks commented Aug 16, 2023

I was thinking that if we wanted, we could add some extra features to the makefiles, such as:

  • optional tests parameter for make test
  • linting only the changed files

However, this repository is so small that linting and testing all the files is very quick, so perhaps that is more trouble than it is worth.

@teroyks teroyks requested a review from ruksi August 16, 2023 11:57
Makefile Outdated Show resolved Hide resolved
Use standard commands (dev, lint, test) for development --
reduces the need to check the README for repository-specific commands.
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that if we wanted, we could add some extra features to the makefiles, such as:

  • optional tests parameter for make test
  • linting only the changed files

However, this repository is so small that linting and testing all the files is very quick, so perhaps that is more trouble than it is worth.

yeah, I'd like to make that you could type make test -- path/to/files or something which would just run those specific tests / lints but I haven't hand the willpower to check if it would even be possible without $VARIABLES :P

for the lint, my personal syntax preference would be make lint.changed but dunno what we collectively land on 🤔

and probably not worth for this repository 👍

@ruksi ruksi merged commit 408458a into master Aug 17, 2023
7 checks passed
@ruksi ruksi deleted the tero-add-makefile branch August 17, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Makefile for better developer experience
3 participants