-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile for development shortcuts #109
Conversation
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 61 61
Lines 1847 1847
Branches 311 311
=======================================
Hits 1710 1710
Misses 70 70
Partials 67 67 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9223364
to
d8cd1b0
Compare
I was thinking that if we wanted, we could add some extra features to the makefiles, such as:
However, this repository is so small that linting and testing all the files is very quick, so perhaps that is more trouble than it is worth. |
d8cd1b0
to
e90b252
Compare
Use standard commands (dev, lint, test) for development -- reduces the need to check the README for repository-specific commands.
e90b252
to
a60ca85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that if we wanted, we could add some extra features to the makefiles, such as:
- optional tests parameter for
make test
- linting only the changed files
However, this repository is so small that linting and testing all the files is very quick, so perhaps that is more trouble than it is worth.
yeah, I'd like to make that you could type make test -- path/to/files
or something which would just run those specific tests / lints but I haven't hand the willpower to check if it would even be possible without $VARIABLES
:P
for the lint, my personal syntax preference would be make lint.changed
but dunno what we collectively land on 🤔
and probably not worth for this repository 👍
Resolves #108
Use standard commands (dev, lint, test) for development – reduces the need to check the README for repository-specific commands.