Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration test script #13

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

joehu21
Copy link
Collaborator

@joehu21 joehu21 commented Nov 29, 2024

Enhance the integration test script to check if environment variable SERVER_VERSION is set. If not, default to "unstable". Also update the README for how to run one integration test.

Details:

  1. Running the integration test using "make test" failed:
Running integration tests against Valkey version: 
.build/binaries//valkey-server missing
make[3]: *** [CMakeFiles/test] Error 1
make[2]: *** [CMakeFiles/test.dir/all] Error 2
make[1]: *** [CMakeFiles/test.dir/rule] Error 2
make: *** [test] Error 2
  1. The root cause is that environment variable SERVER_VERSION is missing.
  2. Fixed by checking if environment variable SERVER_VERSION is set. If not, default to "unstable".

Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@roshkhatri roshkhatri merged commit 373a92e into valkey-io:unstable Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants