Remove static to avoid compiler warning #836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some compilation error which to me looks like a false positive, https://github.com/valkey-io/valkey/actions/runs/10127360669/job/28005048552. It seems very similar to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104165, which is apparently related to miscalculation of static function sizes.
Removing the static just to get the build working, given that most of the codebase still doesn't use static consistently, was thinking about just leaving this way.
NOTE: This would not have been caught with the extra-test label, since we don't run the extra address sanitizers as part of the extra tests, so maybe we should give that this was missed.
Testing
See https://github.com/madolson/valkey/actions/runs/10133662275/job/28019055701 for valida