Fix Valkey binary build workflow, version support changes. #1429
+9
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1429 +/- ##
============================================
+ Coverage 70.76% 70.88% +0.12%
============================================
Files 119 119
Lines 64618 64618
============================================
+ Hits 45728 45806 +78
+ Misses 18890 18812 -78 |
enjoy-binbin
approved these changes
Dec 12, 2024
madolson
added
the
release-notes
|
For future references, future binary releases will have libc issues fixed. (This was mostly reported with TLS) |
madolson
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269 and #1343
This change makes the binary build on the target ubuntu version.
This PR also deprecated ubuntu18 and valkey will not support:
Removed ARM ubuntu 24 as the action we are using for ARM builds does not support Ubuntu 24.