Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter for limiting maximum AOF files size on disk #1425

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

kronwerk
Copy link
Contributor

one can optionally want to limit AOF disk usage not with disk real size, but with some tailored value. this PR makes it possible.
possible use cases:

  1. filling disk up with AOF to the real limit may break something in user's environment (logs, watchdogs, anything) - setting lower value prevents that completely;
  2. setting this new limit to some low value may allow automatic solving of filling disk problem for those users who don't care too much about disk cost:
  • intense writes may overcome automatic AOF rewrite with some user's settings at some moment;
  • AOF reach lower than full disk limit (e.g. 50-60% of disk);
  • eventually automatic AOF rewrite comes in once more and finally fixes that.
    while on 100% filled disk (like nowadays) that automatic solution is impossible due to insufficient space for tmp AOF rewrite files (0 space, actually) - one should size up disk under running database which makes some people a bit nervous, as I noticed, and in some cases that's not always convenient or even possible.

Fixes #540

Signed-off-by: kronwerk <[email protected]>

improved aof-max-size tests

Signed-off-by: kronwerk <[email protected]>
@kronwerk kronwerk marked this pull request as draft December 11, 2024 14:02
Signed-off-by: kronwerk <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (1acf7f7) to head (b57409c).

Files with missing lines Patch % Lines
src/aof.c 85.71% 1 Missing ⚠️
src/server.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1425      +/-   ##
============================================
+ Coverage     70.71%   70.90%   +0.19%     
============================================
  Files           119      119              
  Lines         64652    64625      -27     
============================================
+ Hits          45717    45822     +105     
+ Misses        18935    18803     -132     
Files with missing lines Coverage Δ
src/config.c 77.59% <ø> (-0.06%) ⬇️
src/server.h 100.00% <ø> (ø)
src/aof.c 81.25% <85.71%> (+1.12%) ⬆️
src/server.c 87.48% <83.33%> (-0.09%) ⬇️

... and 43 files with indirect coverage changes

@kronwerk kronwerk marked this pull request as ready for review December 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Limit maximum size on disk of AOF files. Avoid disk full, long load times.
1 participant