Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defrag: use monotime in module interface #1388

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

JimB123
Copy link
Contributor

@JimB123 JimB123 commented Dec 3, 2024

The recent PR (#1242) converted Active Defrag to use monotime. In that change, a conversion was performed to continue to use ustime() as part of the module interface. Since this time is only used internally, and never actually exposed to the module, we can convert this to use monotime directly.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (9f8b174) to head (2d8eb22).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/module.c 0.00% 2 Missing ⚠️
src/defrag.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1388      +/-   ##
============================================
+ Coverage     70.68%   70.86%   +0.18%     
============================================
  Files           118      118              
  Lines         63550    63549       -1     
============================================
+ Hits          44919    45036     +117     
+ Misses        18631    18513     -118     
Files with missing lines Coverage Δ
src/server.h 100.00% <ø> (ø)
src/defrag.c 89.59% <0.00%> (+0.13%) ⬆️
src/module.c 9.64% <0.00%> (ø)

... and 9 files with indirect coverage changes

@hpatro hpatro merged commit 349bc75 into valkey-io:unstable Dec 3, 2024
47 of 48 checks passed
@hpatro
Copy link
Contributor

hpatro commented Dec 3, 2024

The test failure seems unrelated.

@JimB123 JimB123 deleted the module-defrag-monotime branch December 3, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants