Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding guidelines page #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add branding guidelines page #143

wants to merge 1 commit into from

Conversation

kris-ms
Copy link
Contributor

@kris-ms kris-ms commented Sep 27, 2024

Description

With the recent creation of the branding guidelines for Valkey, a web page with the information is in order.
This PR creates a draft for the branding page and is a spot for discussion on improvements/fixes to said page.

I'm a terrible writer so I've not made any real attempts at prose so if there are any suggestions I'm happy to implement!

A screenshot for ease of checking:

image

Issues Resolved

Closes #107 (maybe)

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@stockholmux
Copy link
Member

@kris-ms I'm in favour of adding better web presence for the brand guidelines but I think I'd like them to live in one place, not having it both as a PDF and on the website. I think this PR duplicates everything from the PDF, which is a potential for things to go out-of-sync and causing confusion.

FWIW: The current brand guidelines are good but not quite complete (e.g. it doesn't have things like fonts). So, I do expect them to change.

The assets may have value to have in the repo vs linked to GitHub, but we can do some GitHub Action magic to pull them in without committing them to the repo directly (avoiding duplication and potential out-of-date assets).

Thoughts?

@kris-ms
Copy link
Contributor Author

kris-ms commented Oct 3, 2024

@stockholmux I'm cool with everything that you've mentioned here of course. Do you have some ideas on where you'd prefer to have the single source of truth for the guidelines be located? Is there some way of making it easily maintainable so that the designers can make changes when needed? Then we could simply drag that data in for building the page.

The issue this PR is for seemed to be asking for a page to show the guidelines in their current state, so that's my bad for not checking on plans before moving forward.

If you have a spot for the brand assets (and potentially other general assets i.e. author avatars) to live that is not part of this repo I think that the GH actions route could definitely be the go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a branding page for Valkey
2 participants