Adding node modules in examples app #2615
Open
+209
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
Nov 6, 2024
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: Chloe <[email protected]>
cyip10
force-pushed
the
node/tjz-example
branch
from
02ff3e3
to
2f1cbbd
Compare
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
cyip10
approved these changes
Nov 29, 2024
| const query = "*=>[KNN 2 @VEC $query_vec]"; | ||
|
|
||
| const vectorField_1: VectorField = { | ||
| type: "VECTOR", |
There was a problem hiding this comment.
type is a default field, there is no need to pass this. Is it working without passing this field?
export type VectorField = BaseField & {
/** Field identifier */
type: "VECTOR";
/** Additional attributes to be passed with the vector field after the algorithm name. */
attributes: VectorFieldAttributesFlat | VectorFieldAttributesHnsw;
};
| "@valkey/valkey-glide": "latest", | ||
| "@types/node": "^20.4.8" | ||
| "@types/node": "^20.4.8", | ||
| "@valkey/valkey-glide": "../../node" |
There was a problem hiding this comment.
Please consider adding "uuid" as a dependency, as it is used in vector_search_example.ts
Comment on lines
+43
to
+45
| function setConsoleLogger() { | ||
| Logger.setLoggerConfig("warn"); | ||
| } |
There was a problem hiding this comment.
Duplicate with Logger.setLoggerConfig("warn", "glide.log");?
Comment on lines
+4
to
+5
| import { Decoder, GlideClient, GlideClusterClient, GlideFt, FtSearchOptions, | ||
| FtSearchReturnType, Logger, VectorField} from "@valkey/valkey-glide"; |
There was a problem hiding this comment.
Please consider run linter command npx prettier -w . under example/node to keep consistency with other code in the repo, like the format of this import section, as linter is not enforced on example code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: