support objectEncoding, objectFreq, objectIdletime and objectRefcount… #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with GlideString
eifrah-aws
requested changes
Jun 25, 2024
| @@ -4332,11 +4332,11 @@ public void objectEncoding_returns_null(BaseClient client) { | |||
| @ParameterizedTest(autoCloseArguments = false) | |||
| @MethodSource("getClients") | |||
| public void objectEncoding_returns_string_raw(BaseClient client) { | |||
| String stringRawKey = UUID.randomUUID().toString(); | |||
There was a problem hiding this comment.
We should have both uses cases: String and GlideString
eifrah-aws
approved these changes
Jun 25, 2024
Yury-Fridlyand
approved these changes
Jun 26, 2024
jduo
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 28, 2024
valkey-io#1642) * support objectEncoding, objectFreq, objectIdletime and objectRefcount with GlideString * add to integration tests the use of the API with GlideString parameters * add binary version integration tests * nit: spotlessApply * fix use of GlideString in objectRefcount_returns_null --------- Co-authored-by: Ubuntu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support objectEncoding, objectFreq, objectIdletime and objectRefcount with GlideString