support geodist, getbit, setbit and xack with GlideString #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eifrah-aws
approved these changes
Jun 24, 2024
Yury-Fridlyand
requested changes
Jun 24, 2024
| * members do not exist, or if the key does not exist, returns <code>null</code>. | ||
| * @example | ||
| * <pre>{@code | ||
| * Double result = client.geodist("mySortedSet", "Palermo", "Catania", GeoUnit.KILOMETERS).get(); |
There was a problem hiding this comment.
Suggested change
| * Double result = client.geodist("mySortedSet", "Palermo", "Catania", GeoUnit.KILOMETERS).get(); | |
| * Double result = client.geodist(gs("mySortedSet"), gs("Palermo"), gs("Catania"), GeoUnit.KILOMETERS).get(); |
eifrah-aws
reviewed
Jun 25, 2024
| @@ -4737,6 +4755,8 @@ public void setbit(BaseClient client) { | |||
|
|
|||
| assertEquals(0, client.setbit(key1, 0, 1).get()); | |||
| assertEquals(1, client.setbit(key1, 0, 0).get()); | |||
| assertEquals(0, client.setbit(gs(key1.getBytes()), 0, 1).get()); | |||
There was a problem hiding this comment.
You can use gs(key1) no need for getBytes
| assertEquals(OK, client.set(key1, value).get()); | ||
| assertEquals(1, client.getbit(key1, 1).get()); | ||
| assertEquals(0, client.getbit(key1, 1000).get()); | ||
| assertEquals(0, client.getbit(missingKey, 1).get()); | ||
| assertEquals(1, client.getbit(gs(key1.getBytes()), 1).get()); |
| Double actualKM = client.geodist(key1, member1, member2, geoUnitKM).get(); | ||
| Double actualKM = | ||
| client | ||
| .geodist(gs(key1.getBytes()), gs(member1.getBytes()), gs(member2.getBytes()), geoUnitKM) |
There was a problem hiding this comment.
See comment below: gs can accept string directly
eifrah-aws
approved these changes
Jun 25, 2024
Comment on lines
+3652
to
+3656
| assertEquals( | ||
| 2L, | ||
| client | ||
| .xack(gs(key), gs(groupName), new GlideString[] {gs(streamid_1), gs(streamid_2)}) | ||
| .get()); |
There was a problem hiding this comment.
Please duplicate the test instead of leaving old xack untested - like you did for setbit.
Comment on lines
+4633
to
+4637
| Double actual = client.geodist(gs(key1), gs(member1), gs(member2)).get(); | ||
| assertEquals(expected, actual, delta); | ||
|
|
||
| // assert correct result with manual metric specification kilometers | ||
| Double actualKM = client.geodist(key1, member1, member2, geoUnitKM).get(); | ||
| Double actualKM = client.geodist(gs(key1), gs(member1), gs(member2), geoUnitKM).get(); |
Yury-Fridlyand
approved these changes
Jun 26, 2024
jduo
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 28, 2024
…1635) * support geodist, getbit, setbit and xack with GlideString * add to integration tests the use of the API with GlideString parameters * nit: apply spotlessApply * remove calls to getBytes()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support geodist, getbit, setbit and xack with GlideString