Java: Adding command COPY
#1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzhang-BQ
force-pushed
the
java/integ_tjz_copy
branch
from
809be52
to
c126bb2
Compare
jonathanl-bq
approved these changes
Jun 6, 2024
tjzhang-BQ
force-pushed
the
java/integ_tjz_copy
branch
from
c126bb2
to
e5a071b
Compare
Yury-Fridlyand
approved these changes
Jun 6, 2024
| @@ -946,6 +948,9 @@ InfScoreBound.NEGATIVE_INFINITY, new ScoreBoundary(3, false), new Limit(1, 2)), | |||
| transaction.functionDelete("LIB"); | |||
| results.add(Pair.of(FunctionDelete, buildArgs("LIB"))); | |||
|
|
|||
| transaction.copy("key1", "key2", true); | |||
There was a problem hiding this comment.
test copy with DB index argument
There was a problem hiding this comment.
copy with DB does not work under cluster mode, so it was tested under /standalone/CommandTests.java, is it required here? transaction here is declared as a superclass object and doesn't pull up the copy() signature that is under /api/models/Transaction.java
There was a problem hiding this comment.
I see it is already added. I was confused that number of UTs is less than number of commands added to transaction classes.
* Java: Adding command COPY
tjzhang-BQ
force-pushed
the
java/integ_tjz_copy
branch
from
e5a071b
to
f3cb1ad
Compare
Yury-Fridlyand
approved these changes
Jun 7, 2024
yipin-chen
approved these changes
Jun 7, 2024
acarbonetto
approved these changes
Jun 7, 2024
yipin-chen
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 7, 2024
Java: Adding command COPY (#340) * Java: Adding command COPY
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Java: Adding command COPY (#340) * Java: Adding command COPY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.