Java: Add the XRANGE command #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Java: Add the XRANGE command Signed-off-by: Andrew Carbonetto <[email protected]> * CARGO FMT Signed-off-by: Andrew Carbonetto <[email protected]> * Clean documentation Signed-off-by: Andrew Carbonetto <[email protected]> * Add empty test Signed-off-by: Andrew Carbonetto <[email protected]> * Add empty test Signed-off-by: Andrew Carbonetto <[email protected]> * Update XRANGE for self-review Signed-off-by: Andrew Carbonetto <[email protected]> * Use XRANGE bounding objects Signed-off-by: Andrew Carbonetto <[email protected]> * Add StreamRange documentation Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Fix transaction tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
jonathanl-bq
approved these changes
May 31, 2024
acarbonetto
changed the title
Comment on lines
122
to
123
| * @return A <code>Map</code> of key to stream entry data, where entry data is an array with pairs | ||
| * of item, data. |
There was a problem hiding this comment.
Suggested change
| * @return A <code>Map</code> of key to stream entry data, where entry data is an array with pairs | |
| * of item, data. | |
| * @return A <code>Map</code> of entry ID to entry data. |
We don't have pairs there - I mean we don't return data as pairs. I'd like to say that the data is usually flat pairs, but I don't know how.
There was a problem hiding this comment.
I could say "pairings" to distinguish from the Pair object.
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
tjzhang-BQ
approved these changes
May 31, 2024
| @@ -2659,12 +2661,55 @@ public T xlen(@NonNull String key) { | |||
| * less than the number of entries in <code>ids</code>, if the specified <code>ids</code> | |||
| * don't exist in the stream. | |||
| */ | |||
| public T xdel(String key, String[] ids) { | |||
| public T xdel(@NonNull String key, @NonNull String[] ids) { | |||
There was a problem hiding this comment.
probably small enough to sneak in but was this intentional? changes on another command?
There was a problem hiding this comment.
Yes. This was an intentionally sneaky move...
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add the XRANGE command (#325) * Java: Add the XRANGE command Signed-off-by: Andrew Carbonetto <[email protected]> * CARGO FMT Signed-off-by: Andrew Carbonetto <[email protected]> * Clean documentation Signed-off-by: Andrew Carbonetto <[email protected]> * Add empty test Signed-off-by: Andrew Carbonetto <[email protected]> * Add empty test Signed-off-by: Andrew Carbonetto <[email protected]> * Update XRANGE for self-review Signed-off-by: Andrew Carbonetto <[email protected]> * Use XRANGE bounding objects Signed-off-by: Andrew Carbonetto <[email protected]> * Add StreamRange documentation Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Fix transaction tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * XRANGE udpates for review Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds the XRANGE cmd for the Java client
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.