Standalone Client: Raise an error if more than one primary node is found #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
force-pushed
the
primary_conflict
branch
from
090dedf
to
32b04ff
Compare
eifrah-aws
reviewed
May 30, 2024
|
@eifrah-aws round |
|
Yury-Fridlyand
approved these changes
May 31, 2024
eifrah-aws
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standalone client receives a list of node addresses and tries to find the primary by getting the node's role from 'info replication'. In some cluster issues there might be more than a single primary so the client won't be able to identify which one is the legit primary, and therefore we should fail the client creation.