Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for node:alpine #1379

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

avifenesh
Copy link
Collaborator

@avifenesh avifenesh commented May 3, 2024

Issues - #1205 #1226

Adding support for node on alpine (or any MUSL C library) for arm64 and x64.
Build and tests on arm alpine added to node CI.
Missing exports added since CI fails on them.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avifenesh avifenesh requested a review from a team as a code owner May 3, 2024 11:46
@avifenesh avifenesh force-pushed the feature/node-for-alpine-support branch 29 times, most recently from 264df32 to b0f95ae Compare May 3, 2024 16:15
@avifenesh avifenesh force-pushed the feature/node-for-alpine-support branch 4 times, most recently from 35f6226 to 0bafec9 Compare May 21, 2024 08:37
@avifenesh avifenesh force-pushed the feature/node-for-alpine-support branch 12 times, most recently from c670c58 to db009b7 Compare May 21, 2024 12:47
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, but overall approved

@avifenesh avifenesh force-pushed the feature/node-for-alpine-support branch from db009b7 to 3f013b2 Compare May 21, 2024 13:53
@avifenesh avifenesh merged commit 5eeb673 into main May 21, 2024
51 checks passed
@avifenesh avifenesh deleted the feature/node-for-alpine-support branch May 21, 2024 15:40
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related Feature Additional feature, big or small node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpine versions of languages support Node-Alpine: Initialization Failed
5 participants