-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for node:alpine #1379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
force-pushed
the
feature/node-for-alpine-support
branch
29 times, most recently
from
May 3, 2024 16:15
264df32
to
b0f95ae
Compare
avifenesh
force-pushed
the
feature/node-for-alpine-support
branch
4 times, most recently
from
May 21, 2024 08:37
35f6226
to
0bafec9
Compare
avifenesh
force-pushed
the
feature/node-for-alpine-support
branch
12 times, most recently
from
May 21, 2024 12:47
c670c58
to
db009b7
Compare
barshaul
reviewed
May 21, 2024
barshaul
reviewed
May 21, 2024
barshaul
reviewed
May 21, 2024
barshaul
reviewed
May 21, 2024
barshaul
reviewed
May 21, 2024
barshaul
reviewed
May 21, 2024
barshaul
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, but overall approved
avifenesh
force-pushed
the
feature/node-for-alpine-support
branch
from
May 21, 2024 13:53
db009b7
to
3f013b2
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Added build for musl to node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues - #1205 #1226
Adding support for node on alpine (or any MUSL C library) for arm64 and x64.
Build and tests on arm alpine added to node CI.
Missing exports added since CI fails on them.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.