Fix CI workflows #1364
Fix CI workflows #1364
Conversation
barshaul
force-pushed
the
fix_CI
branch
8 times, most recently
from
60e0971
to
df3c233
Compare
| os: "macos-latest" | ||
| target: "x86_64-apple-darwin" | ||
| os: "macos" | ||
| target: "aarch64-apple-darwin" |
There was a problem hiding this comment.
Why we do it just for aarch and not both arch and x86?
There was a problem hiding this comment.
Same question for ubuntu
There was a problem hiding this comment.
+1 for mac
Re: ubuntu on arm CPU - we never tried it before. Worth adding in scope of another PR.
There was a problem hiding this comment.
@avifenesh out of scope of this PR - can be added in a different one
| - ubuntu-latest | ||
| - macos-latest | ||
| runs-on: ${{ matrix.os }} | ||
| host: |
| os: "macos-latest" | ||
| target: "x86_64-apple-darwin" | ||
| os: "macos" | ||
| target: "aarch64-apple-darwin" |
There was a problem hiding this comment.
+1 for mac
Re: ubuntu on arm CPU - we never tried it before. Worth adding in scope of another PR.
benchmarks/install_and_test.sh
Outdated
There was a problem hiding this comment.
Please, rebase, #1366 already merged
There was a problem hiding this comment.
Re: ubuntu on arm CPU - we never tried it before. Worth adding in scope of another PR.
On our deployment workflows we build for arm64Xubuntu with the self-hosted runner.
We need to open a test to have some minimal integration tests on all platforms, but as I said above - out of scope for this PR
* C#: Added a dotnet framework flag to the C# benchmark * CI: Fix CI workflows to work with MacOS 13 (the version of the new macos-latest runner) * Addressing comments
* C#: Added a dotnet framework flag to the C# benchmark * CI: Fix CI workflows to work with MacOS 13 (the version of the new macos-latest runner) * Addressing comments
Based on #1358.
This PR:
2.The latest MacOS requires installation flag for python installation
Rebased over #1366