Node/dev aarzola alpine fix #1287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-arzola-imp
force-pushed
the
node/dev_aarzola_alpine_fix
branch
from
4b3e27d
to
d3f478b
Compare
barshaul
reviewed
Apr 16, 2024
| named_os: | ||
| description: "The name of the current operating system" | ||
| required: false | ||
| default: "linux" | ||
| type: string | ||
| options: | ||
| - linux | ||
| - linux-musl |
There was a problem hiding this comment.
Please see the comments I wrote on the other PR - we shouldn't use linux-musl here
barshaul
reviewed
Apr 16, 2024
| - darwin | ||
| arch: | ||
| description: "The current architecture" | ||
| required: false | ||
| default: "x64" | ||
| default: "arm64" |
There was a problem hiding this comment.
why? don't change the default
barshaul
reviewed
Apr 16, 2024
.github/workflows/node.yml
Outdated
| os: "ubuntu-latest-musl" | ||
| target: "aarch64-unknown-linux-musl" | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| arch: "x64" |
barshaul
reviewed
Apr 16, 2024
.github/workflows/npm-cd.yml
Outdated
| @@ -54,6 +56,14 @@ jobs: | |||
| TARGET: aarch64-unknown-linux-gnu, | |||
| CONTAINER: "2_28", | |||
| } | |||
| - { | |||
| OS: ubuntu-latest-musl, | |||
| NAMED_OS: linux-musl, | |||
barshaul
reviewed
Apr 16, 2024
| @@ -12,6 +12,7 @@ inputs: | |||
| type: string | |||
| options: | |||
| - linux | |||
| - linux-musl | |||
barshaul
reviewed
Apr 16, 2024
| @@ -17,7 +18,9 @@ function loadNativeBinding() { | |||
| nativeBinding = require("@scope/glide-for-redis-linux-x64"); | |||
| break; | |||
| case "arm64": | |||
| nativeBinding = require("@scope/glide-for-redis-linux-arm64"); | |||
| nativeBinding = existsSync("./node_modules/@scope/glide-for-redis-linux-musl-arm64") | |||
There was a problem hiding this comment.
change to check with isMusl
barshaul
reviewed
Apr 16, 2024
.github/workflows/node.yml
Outdated
| arch: "x64" | ||
| named_os: "linux" | ||
|
|
||
| - name: Create a symbolic Link for redis6 binaries |
There was a problem hiding this comment.
Do we need to step in the alpine image? it's relevant to amazon-linux which installs redis as redis6
acarbonetto
force-pushed
the
node/dev_aarzola_alpine_fix
branch
from
0364f6c
to
97c8031
Compare
acarbonetto
force-pushed
the
node/dev_aarzola_alpine_fix
branch
from
97c8031
to
209a72c
Compare
|
Will continue to keep track in #1267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 1205
Description of changes:
Testing the Alpine Linux to find out where we stand
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.