Java: Add SINTER command.
#1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
barshaul,
acarbonetto,
shohamazon,
SanHalacogluImproving and
ikolomi
SanHalacogluImproving
approved these changes
Apr 9, 2024
jonathanl-bq
approved these changes
Apr 11, 2024
shohamazon
reviewed
Apr 15, 2024
shohamazon
reviewed
Apr 15, 2024
java/client/src/main/java/glide/api/commands/SetBaseCommands.java
Outdated
Show resolved
Hide resolved
shohamazon
reviewed
Apr 15, 2024
java/client/src/main/java/glide/api/commands/SetBaseCommands.java
Outdated
Show resolved
Hide resolved
shohamazon
reviewed
Apr 15, 2024
java/client/src/main/java/glide/api/commands/SetBaseCommands.java
Outdated
Show resolved
Hide resolved
shohamazon
reviewed
Apr 15, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
shohamazon
reviewed
Apr 15, 2024
shohamazon
approved these changes
Apr 16, 2024
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
shohamazon
reviewed
Apr 16, 2024
java/client/src/main/java/glide/api/commands/SetBaseCommands.java
Outdated
Show resolved
Hide resolved
This was referenced Apr 16, 2024
acarbonetto
reviewed
Apr 16, 2024
java/client/src/main/java/glide/api/commands/SetBaseCommands.java
Outdated
Show resolved
Hide resolved
acarbonetto
force-pushed
the
java/integ_yuryf_SINTER
branch
from
9c524c0
to
c857ce1
Compare
* Add `SINTER` command. Signed-off-by: Yury-Fridlyand <[email protected]> * Add response conversion for RESP2. Signed-off-by: Yury-Fridlyand <[email protected]> * Update javadoc. Signed-off-by: Yury-Fridlyand <[email protected]> * javadoc Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/integ_yuryf_SINTER
branch
from
dacb12c
to
ec3dded
Compare
Yury-Fridlyand
commented
Apr 17, 2024
java/client/src/test/java/glide/api/models/TransactionTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Add `SINTER` command. (#181) * Add `SINTER` command. Signed-off-by: Yury-Fridlyand <[email protected]> * Add response conversion for RESP2. Signed-off-by: Yury-Fridlyand <[email protected]> * Update javadoc. Signed-off-by: Yury-Fridlyand <[email protected]> * javadoc Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * Update UT. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix merge conflicts Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <[email protected]> * Reorder enum entries according to Feng Shui. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/commands/sinter/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.