Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add PFCOUNT command. #1222

Merged
merged 10 commits into from
Apr 5, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:
Add HyperHyperLogLog command PFCOUNT - https://redis.io/commands/pfcount/

NOTE This PR depends in #1221

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Add `PFADD` command.

Signed-off-by: Yury-Fridlyand <[email protected]>

* cleanup

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add a test.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Minor fix.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add transaction IT.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <[email protected]>

* PR comments.

Signed-off-by: Yury-Fridlyand <[email protected]>

* PR comments.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
* Add `PFCOUNT` command.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix IT.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <[email protected]>

* PR comments.
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Apr 2, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner April 2, 2024 22:23
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand merged commit 63ab900 into valkey-io:main Apr 5, 2024
42 of 45 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/integ_yuryf_pfcount branch April 5, 2024 04:18
aaron-congo pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 5, 2024
* Add `PFCOUNT` command. (#167)

Signed-off-by: Yury-Fridlyand <[email protected]>
shohamazon pushed a commit to adanWattad/glide-for-redis that referenced this pull request Apr 9, 2024
* Add `PFCOUNT` command. (valkey-io#167)

Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Add `PFCOUNT` command. (#167)

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants