Java: Add BLPOP and BRPOP commands.
#1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `BLPOP` and `BRPOP` commands. Signed-off-by: Yury-Fridlyand <[email protected]> * typo Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Redis 6 fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Increase timeout for standalone client. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
aaron-congo
reviewed
Apr 2, 2024
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
aaron-congo
reviewed
Apr 2, 2024
Signed-off-by: Yury-Fridlyand <[email protected]>
aaron-congo
approved these changes
Apr 3, 2024
| @@ -135,6 +135,7 @@ enum RequestType { | |||
| Rename = 91; | |||
| DBSize = 92; | |||
| Brpop = 93; | |||
| Blpop = 100; | |||
There was a problem hiding this comment.
Why doesn't blpop have the consecutive number?
There was a problem hiding this comment.
There is a number of PRs are pending with numbers in that range
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Elen-Ghulam
approved these changes
Apr 4, 2024
|
@Yury-Fridlyand would you mind resolving conflicts? |
Signed-off-by: Yury-Fridlyand <[email protected]>
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
* Add `BLPOP` and `BRPOP` commands. (valkey-io#174) Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Add `BLPOP` and `BRPOP` commands. (#174) Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add
BLPOPandBRPOPcommands to core and to java wrapperBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.