address remaining comments

valkey-io · Jun 19, 2024 · b9243da · b9243da
1 parent 7681fc5
commit b9243da
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/java/client/src/main/java/glide/api/commands/StringBaseCommands.java b/java/client/src/main/java/glide/api/commands/StringBaseCommands.java
@@ -90,7 +90,7 @@ public interface StringBaseCommands {
      * assert value.equals("value");
      * }</pre>
      */
-    CompletableFuture<String> getex(String key, @NonNull GetExOptions options);
+    CompletableFuture<String> getex(String key, GetExOptions options);
 
     /**
      * Sets the given <code>key</code> with the given value.

diff --git a/java/client/src/main/java/glide/api/models/commands/GetExOptions.java b/java/client/src/main/java/glide/api/models/commands/GetExOptions.java
@@ -47,8 +47,8 @@ public static GetExOptions Seconds(Long seconds) {
     /**
      * Set the specified expire time, in milliseconds. Equivalent to <code>PX</code> in the Redis API.
      *
-     * @param milliseconds The time to expire, in seconds.
-     * @return Expiry
+     * @param milliseconds The time to expire, in milliseconds.
+     * @return The options specifying the given expiry.
      */
     public static GetExOptions Milliseconds(Long milliseconds) {
         return new GetExOptions(MILLISECONDS, milliseconds);
@@ -59,7 +59,7 @@ public static GetExOptions Milliseconds(Long milliseconds) {
      * EXAT</code> in the Redis API.
      *
      * @param unixSeconds The <code>UNIX TIME</code> to expire, in seconds.
-     * @return Expiry
+     * @return The options specifying the given expiry.
      */
     public static GetExOptions UnixSeconds(Long unixSeconds) {
         return new GetExOptions(UNIX_SECONDS, unixSeconds);
@@ -70,7 +70,7 @@ public static GetExOptions UnixSeconds(Long unixSeconds) {
      * PXAT</code> in the Redis API.
      *
      * @param unixMilliseconds The <code>UNIX TIME</code> to expire, in milliseconds.
-     * @return Expiry
+     * @return The options specifying the given expiry.
      */
     public static GetExOptions UnixMilliseconds(Long unixMilliseconds) {
         return new GetExOptions(UNIX_MILLISECONDS, unixMilliseconds);