Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming more redis -> valkey entries #19

Merged
merged 1 commit into from
Dec 6, 2024
Merged

renaming more redis -> valkey entries #19

merged 1 commit into from
Dec 6, 2024

Conversation

tlhunter
Copy link
Collaborator

@tlhunter tlhunter commented Dec 4, 2024 •
edited
Loading

  • most redis.io doc pages have a valkey.io equivalent
  • there is no valkey:// protocol
  • I think we need to make a statement about if/how this will track ioredis
    • e.g. should redis.ts files be renamed valkey.ts? doing so would make it hard to copy upstream changes

mcollina
mcollina approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Collaborator

mcollina commented Dec 5, 2024

Can you sign the dco?

@tlhunter tlhunter force-pushed the tlhunter/more-renaming branch from 34e3d1a to a385bd0 Compare December 6, 2024 04:07
@tlhunter tlhunter merged commit fc9037d into valkey-io:main Dec 6, 2024
15 checks passed
@tlhunter tlhunter deleted the tlhunter/more-renaming branch December 6, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlhunter @mcollina