Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename redis to valkey in readme #18

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

tlhunter
Copy link
Collaborator

Certainly the code samples should all say valkey. Other things I'm not so sure about. I'll need to go over the Valkey website docs and command references and whatnot to update URLs.

Lots of open questions before this can land:

  • Does Valkey use the redis:// protocol identifier? Is there a valkey://?
  • Are all the config properties renamed from redis* to valkey*?

Also, how was this repo forked? Was it from a historical commit before a license change? I suppose Redis inc took over the redis module but ioredis wasn't affected, however as Redis introduced proprietary features I'm guessing ioredis added support and we wanted to revert it?

Certainly the code samples should all say valkey. Other things I'm not so sure about. I'll need to go over the Valkey website docs and command references and whatnot to update URLs.

Lots of open questions before this can land:
- Does Valkey use the `redis://` protocol identifier? Is there a `valkey://`?
- Are all the config properties renamed from redis* to valkey*?

Also, how was this repo forked? Was it from a historical commit before a license change? I suppose Redis inc took over the `redis` module but `ioredis` wasn't affected, however as Redis introduced proprietary features I'm guessing `ioredis` added support and we wanted to revert it?

Signed-off-by: Thomas Hunter II <[email protected]>
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ba1c74b into valkey-io:main Nov 28, 2024
1 check passed
@tlhunter tlhunter deleted the tlhunter-readme-renames branch November 28, 2024 06:51
@mcollina
Copy link
Collaborator

Ops, I took a look and I fat fingered those changes, which I should have done earlier.

  • Does Valkey use the redis:// protocol identifier? Is there a valkey://?

I think it should, but better check on the main repo.

  • Are all the config properties renamed from redis* to valkey*?

I don't think so. We should keep supporting both for migration sake. The goal was a easy migration.

Also, how was this repo forked? Was it from a historical commit before a license change? I suppose Redis inc took over the redis module but ioredis wasn't affected, however as Redis introduced proprietary features I'm guessing ioredis added support and we wanted to revert it?

The main reason this was forked was because ioredis has been in a slow maintenance mode for a long time as Redis Inc put their effort in the module named redis, adding a lot of proprietary feature there, and even cloning/copying the best from ioredis.

A long time ago, @ShogunPanda and myself created a technique called autopipelining and added it to ioredis. Therefore, we know our way around this codebase. Therefore we had the knowledge to maintain this long-term.

Last but not least, I expected the clamp down on all Redis-related things we now see with all the independent clients. I expect all of them to become incompatible with Valkey long term.

At Platformatic, we needed an OSS version for our product, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants