-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Validated Patterns tiers #352
Conversation
This is an automated message: You can preview this docs PR at http://352.docs-pr.validatedpatterns.io |
8c9a0ef
to
89616bc
Compare
content/learn/tested.adoc
Outdated
* A {tested} pattern must be meaningful without specialized hardware, including flavors of architectures not explicitly supported. | ||
+ | ||
Qualification is a {solution-name-upstream} TOC decision with input from the pattern owner. | ||
//AI: What's TOC? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical Oversight Committee
content/learn/tested.adoc
Outdated
//AI: What's TOC? | ||
* A {tested} pattern must have their implementation reviewed by the patterns team to ensure that it is sufficiently flexible to function across a variety of platforms, customer environments, and any relevant verticals. | ||
* A {tested} pattern must include a standardized architecture drawing, created with (or at least conforming to) the PAC tooling | ||
//AI: What's PAC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Portfolio Architecture Council
content/learn/tested.adoc
Outdated
Qualification is a {solution-name-upstream} TOC decision with input from the pattern owner. | ||
//AI: What's TOC? | ||
* A {tested} pattern must have their implementation reviewed by the patterns team to ensure that it is sufficiently flexible to function across a variety of platforms, customer environments, and any relevant verticals. | ||
* A {tested} pattern must include a standardized architecture drawing, created with (or at least conforming to) the PAC tooling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* A {tested} pattern must include a standardized architecture drawing, created with (or at least conforming to) the PAC tooling | |
* A {tested} pattern must include a standardized architecture drawing, created with (or at least conforming to) the standard Patterns tooling |
content/learn/implementation.adoc
Outdated
. Patterns must be useful without all content stored in private Git repositories. | ||
. Patterns must include a list of names and versions of all the products and projects that the pattern consumes. | ||
. Patterns must be useful without any sample applications that are private or that lack public sources. | ||
//AI:why application was styled that way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was probably using it as a Noun elsewhere in the list
60420bf
to
4cbcd96
Compare
/lgtm |
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Avani,
Just found some minor issues. Overall, the content is great. Nice job!
content/learn/tested.adoc
Outdated
+ | ||
//TODO: Convert above link to adoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plus sign here necessary due to the next line being a comment?
…ut certain verbiage
Ignoring the html test errors. These seem to for the renamed files and are sort of false positive. Raised an query with the htmltest repo. Not holding merge for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addresses all feedback
* A {maintained} pattern must be tested on all currently supported {rh-ocp} extended update support (EUS) releases. | ||
* A {maintained} pattern must fix breakage in timely manner. | ||
* A {maintained} pattern must document their support policy. | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all the list continuation (+) here are required because they are a continuation on the support policy and statement.
content/learn/tested.adoc
Outdated
* A {tested} pattern must include a test plan covering all features or attributes being highlighted by the demonstration guide. Negative flow tests (such as resiliency or data retention in the presence of network outages) are also limited to scenarios covered by the demonstration guide. | ||
+ | ||
The test plan must define how to validate if the pattern has been successfully deployed and is functionally operational. | ||
Example: https://docs.google.com/document/d/12KQhdzjVIsxRURTnWAckiEMB3_96oWBjtlTXi1q73cg/view[Validating an Industrial Edge Deployment] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't. It renders as interned since it's seen as ventilated prose
Based on #319
Issue: https://issues.redhat.com/browse/TELCODOCS-1521
Preview: http://352.docs-pr.validatedpatterns.io/learn/workflow/