Change the JVM settings to work with Trino version 433. (#193)

* Change the JVM settings to work with Trino version 433. I am following the settings from the official chart and am not adding the GCLockerRetryAllocationCount configuration because I believe it can vary for each use case. trinodb/charts@bcef55c * update helm-docs version * Update chart-test-action
valeriano-manassero · Nov 21, 2023 · 2dea47b · 2dea47b
1 parent 2129571
commit 2dea47b
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 18 deletions.
diff --git a/.github/helm-docs.sh b/.github/helm-docs.sh
@@ -6,9 +6,9 @@ if [[ -z "$CHART_DIRS" ]]; then
     exit 1
 fi
 
-HELM_DOCS_VERSION="1.11.2"
+HELM_DOCS_VERSION="1.11.3"
 
-curl --silent --show-error --fail --location --output /tmp/helm-docs.tar.gz https://github.com/norwoodj/helm-docs/releases/download/v"${HELM_DOCS_VERSION}"/helm-docs_Linux_x86_64.tar.gz
+curl --silent --show-error --fail --location --output /tmp/helm-docs.tar.gz https://github.com/norwoodj/helm-docs/releases/download/v"${HELM_DOCS_VERSION}"/helm-docs_"${HELM_DOCS_VERSION}"_Linux_x86_64.tar.gz
 tar -xf /tmp/helm-docs.tar.gz helm-docs
 
 for CHART_DIR in ${CHART_DIRS}; do

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -37,7 +37,7 @@ jobs:
         with:
           node_image: kindest/node:${{ matrix.k8s }}
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@v2.4.0
+        uses: helm/chart-testing-action@v2.6.1
       - name: Run chart-testing (list-changed)
         id: list-changed
         run: |

diff --git a/valeriano-manassero/trino/Chart.yaml b/valeriano-manassero/trino/Chart.yaml
@@ -1,8 +1,8 @@
 apiVersion: v1
-appVersion: "426"
+appVersion: "433"
 description: High performance, distributed SQL query engine for big data
 name: trino
-version: 8.0.0
+version: 9.0.0
 kubeVersion: ">= 1.24.0-0 < 1.29.0-0"
 home: https://trino.io
 icon: https://trino.io/assets/images/trino-logo/trino-ko_tiny-alt.svg
@@ -27,4 +27,4 @@ keywords:
 annotations:
   artifacthub.io/changes: |
     - kind: changed
-      description: enanched SecurityContext for pod and containers
+      description: modify JVM configurations to work with 433 version
diff --git a/valeriano-manassero/trino/README.md b/valeriano-manassero/trino/README.md
@@ -1,6 +1,6 @@
 # trino
 
-![Version: 8.0.0](https://img.shields.io/badge/Version-8.0.0-informational?style=flat-square) ![AppVersion: 426](https://img.shields.io/badge/AppVersion-426-informational?style=flat-square)
+![Version: 9.0.0](https://img.shields.io/badge/Version-9.0.0-informational?style=flat-square) ![AppVersion: 433](https://img.shields.io/badge/AppVersion-433-informational?style=flat-square)
 
 High performance, distributed SQL query engine for big data
 
@@ -94,7 +94,7 @@ Kubernetes: `>= 1.24.0-0 < 1.29.0-0`
 | groupProvider | object | `{}` |  |
 | image.pullPolicy | string | `"IfNotPresent"` |  |
 | image.repository | string | `"trinodb/trino"` |  |
-| image.tag | int | `426` |  |
+| image.tag | int | `433` |  |
 | imagePullSecrets | list | `[]` |  |
 | ingress.annotations | object | `{}` |  |
 | ingress.enabled | bool | `false` |  |
@@ -137,4 +137,4 @@ Kubernetes: `>= 1.24.0-0 < 1.29.0-0`
 | tls.tlsEncryptionSecretName | string | `""` |  |
 
 ----------------------------------------------
-Autogenerated from chart metadata using [helm-docs v1.11.2](https://github.com/norwoodj/helm-docs/releases/v1.11.2)
+Autogenerated from chart metadata using [helm-docs v1.11.3](https://github.com/norwoodj/helm-docs/releases/v1.11.3)
diff --git a/valeriano-manassero/trino/templates/configmap-coordinator.yaml b/valeriano-manassero/trino/templates/configmap-coordinator.yaml
@@ -13,22 +13,21 @@ data:
 
   jvm.config: |
     -server
+    -agentpath:/usr/lib/trino/bin/libjvmkill.so
     -XX:InitialRAMPercentage={{ .Values.config.coordinator.jvm.maxRAMPercentage }}
     -XX:MaxRAMPercentage={{ .Values.config.coordinator.jvm.maxRAMPercentage }}
     -XX:+{{ .Values.config.coordinator.jvm.gcMethod.type }}
     -XX:G1HeapRegionSize={{ .Values.config.coordinator.jvm.gcMethod.g1.heapRegionSize }}
-    -XX:+UseGCOverheadLimit
     -XX:+ExplicitGCInvokesConcurrent
     -XX:+HeapDumpOnOutOfMemoryError
     -XX:+ExitOnOutOfMemoryError
-    -Djdk.attach.allowAttachSelf=true
-    -XX:-UseBiasedLocking
+    -XX:-OmitStackTraceInFastThrow
     -XX:ReservedCodeCacheSize=512M
     -XX:PerMethodRecompilationCutoff=10000
     -XX:PerBytecodeRecompilationCutoff=10000
+    -Djdk.attach.allowAttachSelf=true
     -Djdk.nio.maxCachedBufferSize=2000000
     -XX:+UnlockDiagnosticVMOptions
-    -XX:+UseAESCTRIntrinsics
 {{- if .Values.jmxExporter.coordinator.enabled }}
     -javaagent:{{ .Values.jmxExporter.path }}/lib/{{ .Values.jmxExporter.jarfile }}={{ .Values.jmxExporter.port }}:{{ .Values.jmxExporter.path }}/etc/trino.yaml
 {{- end }}

diff --git a/valeriano-manassero/trino/templates/configmap-worker.yaml b/valeriano-manassero/trino/templates/configmap-worker.yaml
@@ -14,22 +14,21 @@ data:
 
   jvm.config: |
     -server
+    -agentpath:/usr/lib/trino/bin/libjvmkill.so
     -XX:InitialRAMPercentage={{ .Values.config.worker.jvm.maxRAMPercentage }}
     -XX:MaxRAMPercentage={{ .Values.config.worker.jvm.maxRAMPercentage }}
     -XX:+{{ .Values.config.worker.jvm.gcMethod.type }}
     -XX:G1HeapRegionSize={{ .Values.config.worker.jvm.gcMethod.g1.heapRegionSize }}
-    -XX:+UseGCOverheadLimit
     -XX:+ExplicitGCInvokesConcurrent
     -XX:+HeapDumpOnOutOfMemoryError
     -XX:+ExitOnOutOfMemoryError
-    -Djdk.attach.allowAttachSelf=true
-    -XX:-UseBiasedLocking
+    -XX:-OmitStackTraceInFastThrow
     -XX:ReservedCodeCacheSize=512M
     -XX:PerMethodRecompilationCutoff=10000
     -XX:PerBytecodeRecompilationCutoff=10000
+    -Djdk.attach.allowAttachSelf=true
     -Djdk.nio.maxCachedBufferSize=2000000
     -XX:+UnlockDiagnosticVMOptions
-    -XX:+UseAESCTRIntrinsics
 {{- if .Values.jmxExporter.worker.enabled }}
     -javaagent:{{ .Values.jmxExporter.path }}/lib/{{ .Values.jmxExporter.jarfile }}={{ .Values.jmxExporter.port }}:{{ .Values.jmxExporter.path }}/etc/trino.yaml
 {{- end }}

diff --git a/valeriano-manassero/trino/values.yaml b/valeriano-manassero/trino/values.yaml
@@ -1,6 +1,6 @@
 image:
   repository: trinodb/trino
-  tag: 426
+  tag: 433
   pullPolicy: IfNotPresent
 
 fullnameOverride: trino