optimize svg loading, run tsc in lint to check types, don't include extra copies of the fonts in the assets folder #3
Conversation
…xtra copies of the fonts in the assets folder
|
|
|
I'm not sure which part of the code changes is the optimization. Is it the change from |
|
Just a bunch of little things, FileReader is way faster comparatively (especially in Firefox) but they're both pretty fast so it doesn't matter a ton, the fewer DOM operations helped a bit, I tried to make fewer allocations but I didn't actually test that |
|
I changed the structure of the font loading code back to the previous one while retaining those optimizations. Can you pull that and check if it's still the same speed? |
|
You should keep the isFont, it's more idiomatic typescript. |
|
Added it back in. Is the performance still the same as in your original PR? |
|
seems about 0.8s slower at loading 1029722049 start to finish (just averaged over 7 runs each (refreshed before running) cus they're kinda long lol) (... which might not actually be enough to be statistically significant) |
|
I measured loading 1029722049 and there's a huge amount of variation on the order of seconds, seemingly due to differences in how long it takes to render the parsed SVGs. I'm probably going to merge this as-is |
No description provided.