Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giffy-break as a non-iTerm fallback #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsblv
Copy link
Contributor

@dsblv dsblv commented Mar 7, 2016

I've got inspired by this module (and by Windows not being able to run it), so I created giffy-break — a reusable module that locally serves a page with random gifs as long as supplied promise is beign resolved.

I think it'd be nicer alternative to just opening gifs repeatedly in a viewer. It also a bit faster by using mp4-encoded gifs!


upd: here's what it looks like

@vadimdemedes
Copy link
Owner

Could you please record a short video of how it works and send the link here, so that I can check it out in action?

@dsblv
Copy link
Contributor Author

dsblv commented Mar 7, 2016

Sure, I was planning to do it anyways.

@dsblv
Copy link
Contributor Author

dsblv commented Mar 7, 2016

@vdemedes please take a look 😉 https://www.dropbox.com/s/wtzjm9e9dzafeib/gifi-with-giffy-break.mp4?dl=0

@dsblv
Copy link
Contributor Author

dsblv commented Mar 7, 2016

I noticed that you support older versions of node by demand (#12). This PR will definitelty break it, so feel free to close.

@vadimdemedes
Copy link
Owner

Damn, I like it, I'd be happy to merge giffy in! Why can't it be compatible with older versions of Node.js?

@dsblv
Copy link
Contributor Author

dsblv commented Mar 7, 2016

Thanks!

I can see it may be too early for us to force everyone go latest node (I would if I were you though).

I'll switch giffy-break to ES5 and notify you, stay tuned 😉

@dsblv
Copy link
Contributor Author

dsblv commented Mar 7, 2016

Wait a minute, you depend on got@6 which doesn't support node < 4 either!

Is it a bug, or maybe everyone is just happy to use node 4?

@dsblv
Copy link
Contributor Author

dsblv commented Mar 7, 2016

Hooray, @vdemedes, I finally did it!

@vadimdemedes
Copy link
Owner

Awesome, could you please rebase to fix conflicts?

@dsblv
Copy link
Contributor Author

dsblv commented Mar 8, 2016

Done 👌 (Not sure if done right, I'm new to rebasing)

@vadimdemedes
Copy link
Owner

Just tried this PR in action and I only get to see one GIF and then "Here you go", but gifi install is still going. Any clues why this is happening?

@egoist
Copy link

egoist commented Mar 8, 2016

I made a module to get iTerm version so that it can fallback in Iterm < 2.9 too 😅

maybe you need this https://github.com/egoist/iterm-version

@vadimdemedes
Copy link
Owner

Hell yes, @egoist, thank you!

@dsblv
Copy link
Contributor Author

dsblv commented Mar 8, 2016

Any clues why this is happening?

Yeah, It happened because I wasn't explicitly clearing timeout after the last gif: npm process exits, but gifi lasts about 3 more seconds while timeout is still set.

Fixed and published a patch to giffy-break. Thanks for the report!

@vadimdemedes
Copy link
Owner

I tested it again and I'm seeing the same issue. Reinstalled fresh dependencies and no fix. Could you please confirm?

@dsblv
Copy link
Contributor Author

dsblv commented Mar 14, 2016

It works perfectly well for me for some reason 😬 Not a single lag or something.

Which is actually a bad thing, I need this reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants