-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
giffy-break as a non-iTerm fallback #24
base: master
Are you sure you want to change the base?
Conversation
Could you please record a short video of how it works and send the link here, so that I can check it out in action? |
Sure, I was planning to do it anyways. |
@vdemedes please take a look 😉 https://www.dropbox.com/s/wtzjm9e9dzafeib/gifi-with-giffy-break.mp4?dl=0 |
I noticed that you support older versions of node by demand (#12). This PR will definitelty break it, so feel free to close. |
Damn, I like it, I'd be happy to merge |
Thanks! I can see it may be too early for us to force everyone go latest node (I would if I were you though). I'll switch |
Wait a minute, you depend on Is it a bug, or maybe everyone is just happy to use node 4? |
Hooray, @vdemedes, I finally did it! |
Awesome, could you please rebase to fix conflicts? |
Done 👌 (Not sure if done right, I'm new to rebasing) |
Just tried this PR in action and I only get to see one GIF and then "Here you go", but |
I made a module to get iTerm version so that it can fallback in Iterm < 2.9 too 😅 maybe you need this https://github.com/egoist/iterm-version |
Hell yes, @egoist, thank you! |
Yeah, It happened because I wasn't explicitly clearing timeout after the last gif: Fixed and published a patch to |
I tested it again and I'm seeing the same issue. Reinstalled fresh dependencies and no fix. Could you please confirm? |
It works perfectly well for me for some reason 😬 Not a single lag or something. Which is actually a bad thing, I need this reproduced. |
I've got inspired by this module (and by Windows not being able to run it), so I created
giffy-break
— a reusable module that locally serves a page with random gifs as long as suppliedpromise
is beign resolved.I think it'd be nicer alternative to just opening gifs repeatedly in a viewer. It also a bit faster by using
mp4
-encoded gifs!upd: here's what it looks like