Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print to stderr any error obtained while executing functions via FFI #200

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Aug 8, 2023

This will help users of the library to get a reason on why a function is failing so we can help with support and reduce guesswork.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Benchmark for f6c5d74

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1569.7±53.38ns 1609.5±57.66ns +2.54%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.9±0.06µs 4.0±0.09µs +2.56%
FullMerkleTree::set 1571.0±83.71ns 1596.7±87.39ns +1.64%
OptimalMerkleTree::compute_root 1758.8±40.22ns 1826.1±195.36ns +3.83%
OptimalMerkleTree::delete 1785.5±139.70ns 1806.3±70.68ns +1.16%
OptimalMerkleTree::get 38.1±1.09ns 38.0±4.12ns -0.26%
OptimalMerkleTree::override_range 8.9±0.24µs 8.9±0.28µs 0.00%
OptimalMerkleTree::set 1749.9±40.49ns 1797.5±40.70ns +2.72%

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Benchmark for f6c5d74

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.03ns 2.0±0.03ns 0.00%
Pmtree::get 535.3±8.37ns 545.5±7.27ns +1.91%
Pmtree::override_range 204.9±5.65µs 213.1±24.71µs +4.00%
Pmtree::set 83.0±1.81µs 76.7±1.18µs -7.59%
Pmtree:delete 83.0±1.19µs 77.4±1.10µs -6.75%

@rymnc rymnc added this to the Release v0.4.0 milestone Aug 9, 2023
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as an initial iteration for error handling

Copy link
Contributor

@tyshko-rostyslav tyshko-rostyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, we'll need to enhance it

@rymnc rymnc merged commit 99966d1 into master Aug 9, 2023
@rymnc rymnc deleted the print-err branch August 9, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants