-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gennet + Starlark: specifying inter-subnetwork QoS requirements #128
Open
0xFugue
wants to merge
43
commits into
master
Choose a base branch
from
0xFugue-gennet-QoS
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFugue
changed the title
Gennet: Inter-subnetwork QoS
Gennet: generating inter-subnetwork QoS spec
Jun 9, 2023
0xFugue
changed the title
Gennet: generating inter-subnetwork QoS spec
Gennet + Starlark: specifying inter-subnetwork QoS requirements
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds inter-subnetwork QoS generation functionality to Gennet and to Starlark. This can be exercised via config.json: the user can specify one or more QoS distributions (
Uniform
,Normal
) Unthat range over the edges of the subnetwork. The users now can also completely block the traffic (Block
) or have allow free flow of traffic (None
).config.json specifies a meta-QoS distribution that Gennet interprets and creates the final (loss rate (in %), delay distribution, delay (in ms) triplet for every edge.
Fixes couple of minor issues and improves performance of Gennet.
Also, deletes the signal fifo at the end of sim, and few other tweaks.
Closes #127 and #81