feat: introduce StakeVault and IStakeManager
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
chore/stake-vault
branch
3 times, most recently
from
d4b25c8
to
c8b8c3e
Compare
0x-r4bbit
changed the title
StakeVault and IStakeManager
0x-r4bbit
force-pushed
the
chore/stake-vault
branch
from
c8b8c3e
to
714c884
Compare
3 tasks
0x-r4bbit
commented
Oct 17, 2024
| function MAX_LOCKUP_PERIOD() external view returns (uint256); | ||
| function MP_RATE_PER_YEAR() external view returns (uint256); | ||
| function MAX_MULTIPLIER() external view returns (uint256); | ||
| } |
There was a problem hiding this comment.
@3esmit I left out functions that aren't yet compatible with the reward streamer:
- Upgradeability
- Exiting
- Locking after stake
Will address those in future PRs
0x-r4bbit
commented
Oct 17, 2024
| function amountStaked() public view returns (uint256) { | ||
| return stakeManager.getStakedBalance(address(this)); | ||
| } | ||
| } |
There was a problem hiding this comment.
@3esmit In this vault implementation I remove the functions to withdraw ETH.
The reason being is that this contract doesn't have any payable functions or fallback/receive implementations, so it can't receive any ETH anyways.
0x-r4bbit
force-pushed
the
refactor/user-account
branch
from
45b2ec5
to
7c18c8b
Compare
This introduces a first version of `IStakeManager`, highly inspired by the changes done in #39. However, in this commit, it only adds the methods that are currently supported by both, `StakeManager` and `RewardStreamerMP`. Future commits will add APIs for locking and leaving.
0x-r4bbit
force-pushed
the
chore/stake-vault
branch
from
714c884
to
03e11e8
Compare
gravityblast
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits do the following:
StakeVaultwhich actually works with RewardStreamerMPIStakeManagerthat asks for functions that are currently supported by the protocolThis work is highly inspired by @3esmit work in #39 but sliced into smaller chunks for easier review and so that we can start landing some of those changes.
This does currently not add
TrustedCodehashAccesscontract and interface #63lock()on reward streamer contract #40)And leaving the system. (#66 )
Again, most of this work was done by @3esmit, this PR just makes some of the changes in #39 mergeable
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?