Remove log, fix test

vaadin · Oct 14, 2024 · 535c1c7 · 535c1c7
1 parent 689fd64
commit 535c1c7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/vaadin-platform-react-hybrid-test/src/main/frontend/views/hilla/@layout.tsx b/vaadin-platform-react-hybrid-test/src/main/frontend/views/hilla/@layout.tsx
@@ -31,7 +31,6 @@ export default function Layout() {
                         location={location}>
                         {
                             createMenuItems().filter(({to}) => {
-                                 console.log("+++", to);
                                 return to.startsWith("hilla") || to.startsWith("/hilla");
                             }).map(({ to, icon, title }) => (
                                 <SideNavItem path={to} key={to}>

diff --git a/vaadin-platform-react-hybrid-test/src/main/frontend/views/hilla/components.tsx b/vaadin-platform-react-hybrid-test/src/main/frontend/views/hilla/components.tsx
@@ -81,7 +81,7 @@ export default function Components() {
     }
 
     return (
-        <VerticalLayout theme="padding">
+        <VerticalLayout theme="padding" id={"components"}>
             <Accordion>
                 <AccordionPanel>
                     <AccordionHeading slot="summary">summary</AccordionHeading>
@@ -237,7 +237,7 @@ export default function Components() {
 
             <LoginForm></LoginForm>
 
-            <Button onClick={() => openLoginOverlay()}>Open Login
+            <Button onClick={() => openLoginOverlay()} id={"open-overlay"}>Open Login
                 Overlay</Button>
             <LoginOverlay></LoginOverlay>
 

diff --git a/...platform-react-hybrid-test/src/test/java/com/vaadin/platform/react/test/ComponentsIT.java b/...platform-react-hybrid-test/src/test/java/com/vaadin/platform/react/test/ComponentsIT.java
@@ -29,8 +29,10 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.vaadin.flow.component.button.testbench.ButtonElement;
 import com.vaadin.flow.component.login.testbench.LoginOverlayElement;
 import com.vaadin.flow.component.notification.testbench.NotificationElement;
+import com.vaadin.flow.component.orderedlayout.testbench.VerticalLayoutElement;
 
 public class ComponentsIT extends AbstractPlatformTest {
 
@@ -42,8 +44,10 @@ public void loadComponents() throws Exception {
     $(NotificationElement.class).waitForFirst();
 
     // Do something with the view
-    WebElement view = $("components-view").first().getWrappedElement();
-    getCommandExecutor().executeScript("arguments[0].openLoginOverlay()", view);
+    VerticalLayoutElement mainLayout = $(VerticalLayoutElement.class).id(
+            "components");
+    mainLayout.$(ButtonElement.class).id("open-overlay").click();
+
     assertNotNull($(LoginOverlayElement.class).waitForFirst());
   }