Skip to content

Commit

Permalink
chore: make hybrid dev module a provided dependency (#6918) (#7023)
Browse files Browse the repository at this point in the history
vaadin-dev-bundle requires vaadin-hybrid-dev-bundle only to extract the hybrid
package-lock.json file. It necessary to have the hybrid bundle module as a
project dependency, to make sure modules are executed in the correct order by
maven reactor. However, the scope of the hybrid dependency must be provided
to prevent the flow maven plugin to find its stats.json in classpath and
then refusing to create a new dev bundle.

Co-authored-by: Marco Collovati <[email protected]>
Co-authored-by: Zhe Sun <[email protected]>
  • Loading branch information
3 people authored Nov 21, 2024
1 parent c84b532 commit 3b2c1e5
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions scripts/generator/templates/template-dev-bundle-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,17 @@
</properties>

<dependencies>
<!--
vaadin-hybrid-dev-bundle must be a project dependency otherwise it will be built
after vaadin-dev-bundle because of modules configuration in root pom.
Configuring the dependency with provided scope will prevent it to be scanned by
flow-dev-bundle-plugin.
-->
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>vaadin-hybrid-dev-bundle</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
<optional>true</optional>
</dependency>
<dependency>
Expand Down

0 comments on commit 3b2c1e5

Please sign in to comment.