Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the etcdctl proc call with etcd client. #1970

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Replace the etcdctl proc call with etcd client. #1970

merged 2 commits into from
Aug 15, 2024

Conversation

dashanji
Copy link
Member

@dashanji dashanji commented Aug 2, 2024

What do these changes do?

As titled

Related issue number

Fixes #1945

@dashanji dashanji changed the title [WIP] Replace the etcdctl proc call with etcd client. Replace the etcdctl proc call with etcd client. Aug 9, 2024
@dashanji dashanji force-pushed the replace-etcdctl-with-client-cppv3 branch 3 times, most recently from b3bc65c to 59d8817 Compare August 9, 2024 07:08
@dashanji dashanji force-pushed the replace-etcdctl-with-client-cppv3 branch from 59d8817 to 5ca8dc7 Compare August 9, 2024 08:46
@dashanji dashanji changed the title Replace the etcdctl proc call with etcd client. [WIP] Replace the etcdctl proc call with etcd client. Aug 9, 2024
@dashanji
Copy link
Member Author

dashanji commented Aug 9, 2024

The e2e-tests-five-etcd-nodes-failover always failed, wait for debugging.

@dashanji dashanji force-pushed the replace-etcdctl-with-client-cppv3 branch 2 times, most recently from 70cdbb1 to 78629b2 Compare August 13, 2024 09:10
@dashanji dashanji changed the title [WIP] Replace the etcdctl proc call with etcd client. Replace the etcdctl proc call with etcd client. Aug 14, 2024
@dashanji dashanji force-pushed the replace-etcdctl-with-client-cppv3 branch from 2bb5e11 to 4bb3e14 Compare August 14, 2024 04:19
@dashanji dashanji force-pushed the replace-etcdctl-with-client-cppv3 branch from 4bb3e14 to dbfbf1c Compare August 14, 2024 05:47
@sighingnow sighingnow merged commit 55c9058 into v6d-io:main Aug 15, 2024
21 of 26 checks passed
@sighingnow sighingnow deleted the replace-etcdctl-with-client-cppv3 branch August 15, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate the etcdctl control API to etcd-cpp-apiv3 to avoid subprocess call
2 participants
@dashanji @sighingnow