Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement etcd lifecycle management for vineyardd #1932

Merged
merged 19 commits into from
Jul 18, 2024
Merged

Implement etcd lifecycle management for vineyardd #1932

merged 19 commits into from
Jul 18, 2024

Conversation

dashanji
Copy link
Member

@dashanji dashanji commented Jul 1, 2024

What do these changes do?

  • Add the etcdctl cmd flag.
  • Launch an etcd instance when start a vineyardd instance.
  • Remove the related etcd member when a vineyardd instance exit.

Related issue number

Fixes #1922

@dashanji dashanji changed the title Implement etcd lifecycle management for vineyardd [WIP] Implement etcd lifecycle management for vineyardd Jul 1, 2024
dashanji added 4 commits July 1, 2024 23:59
@dashanji
* Add the etcdctl cmd flag.
044e8d0 
* Launch an etcd instance when start a vineyardd instance.
* Remove the related etcd member when a vineyardd instance exit.

Signed-off-by: Ye Cao <[email protected]>
@dashanji
Remove the etcd member if it's not started successfully.
d6306a4 
Signed-off-by: Ye Cao <[email protected]>
@dashanji
Not to create a new metadata instance when create a new session.
e8b609b 
Signed-off-by: Ye Cao <[email protected]>
@dashanji
Fix ci error.
015255e 
Signed-off-by: Ye Cao <[email protected]>
@dashanji dashanji force-pushed the manage-etcd-member branch from d245b0d to 015255e Compare July 2, 2024 07:26
@dashanji
Lint python code
c90d553 
Signed-off-by: Ye Cao <[email protected]>
@dashanji dashanji force-pushed the manage-etcd-member branch from 0aab373 to c90d553 Compare July 2, 2024 08:22
@dashanji
Fix ci error.
3438704 
Signed-off-by: Ye Cao <[email protected]>
@dashanji dashanji force-pushed the manage-etcd-member branch from 2aea293 to 3438704 Compare July 2, 2024 08:56
@dashanji dashanji changed the title [WIP] Implement etcd lifecycle management for vineyardd Implement etcd lifecycle management for vineyardd Jul 2, 2024
@dashanji dashanji requested review from sighingnow and vegetableysm and removed request for sighingnow July 2, 2024 12:01
@dashanji dashanji force-pushed the manage-etcd-member branch from b69777c to 6d42611 Compare July 2, 2024 15:52
@dashanji
Minor
391018f 
Signed-off-by: Ye Cao <[email protected]>
@dashanji dashanji force-pushed the manage-etcd-member branch from 6d42611 to 391018f Compare July 2, 2024 16:20
sighingnow
sighingnow reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would better integrate these etcd member control APIs into etcd-cpp-apiv3 and avoid subprocess calls later.

sighingnow
sighingnow reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test suite to ensure it works.

@dashanji
Copy link
Member Author

dashanji commented Jul 3, 2024

Please add a test suite to ensure it works.

Okay.

@dashanji dashanji force-pushed the manage-etcd-member branch 3 times, most recently from f9861c7 to 9afe36a Compare July 3, 2024 08:55
@dashanji dashanji force-pushed the manage-etcd-member branch from 9afe36a to 8a13b9b Compare July 3, 2024 11:31
@dashanji
Copy link
Member Author

Please add a test suite to ensure it works.

Done.

@sighingnow Could you please take a look at this?

@dashanji dashanji changed the title Implement etcd lifecycle management for vineyardd [WIP] Implement etcd lifecycle management for vineyardd Jul 11, 2024
@dashanji dashanji force-pushed the manage-etcd-member branch from 7d0796a to 4aa2af2 Compare July 15, 2024 02:43
@dashanji
* Improve the etcdctl control API.
4164ae2 
* Add the e2e test for etcd nodes failover.

Signed-off-by: Ye Cao <[email protected]>
@dashanji dashanji force-pushed the manage-etcd-member branch from 4aa2af2 to 4164ae2 Compare July 15, 2024 02:47
@dashanji dashanji changed the title [WIP] Implement etcd lifecycle management for vineyardd Implement etcd lifecycle management for vineyardd Jul 15, 2024
@sighingnow sighingnow merged commit 781e4d1 into v6d-io:main Jul 18, 2024
22 of 26 checks passed
@sighingnow sighingnow deleted the manage-etcd-member branch July 18, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighingnow sighingnow sighingnow left review comments

@vegetableysm vegetableysm Awaiting requested review from vegetableysm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start the vineyard and etcd together one by one for better scale up and down
2 participants
@dashanji @sighingnow