Delete the cert manager dependencies and generate the self-signed CA for webhook. #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashanji
changed the title
dashanji
force-pushed
the
delete-the-cert-manager
branch
3 times, most recently
from
bc1d47d to
5375907
Compare
dashanji
changed the title
dashanji
force-pushed
the
delete-the-cert-manager
branch
from
5375907 to
3bd8a84
Compare
sighingnow
requested changes
Jan 9, 2024
| #- patches/cainjection_in_sidecars.yaml | ||
| #- patches/cainjection_in_backups.yaml | ||
| #- patches/cainjection_in_recovers.yaml | ||
| #- patches/cainjection_in_csidrivers.yaml | ||
| # +kubebuilder:scaffold:crdkustomizecainjectionpatch |
There was a problem hiding this comment.
Remove those blocks if they are no longer needed...
| # objref: | ||
| # kind: Service | ||
| # version: v1 | ||
| # name: webhook-service |
dashanji
force-pushed
the
delete-the-cert-manager
branch
2 times, most recently
from
93ab546 to
269cfe9
Compare
Signed-off-by: Ye Cao <[email protected]>
dashanji
force-pushed
the
delete-the-cert-manager
branch
from
269cfe9 to
e0d5552
Compare
sighingnow
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
Fixes #1680