Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unit test error and adjust the condition for fetching objects #1703

Merged

Conversation

dashanji
Copy link
Member

@dashanji dashanji commented Dec 29, 2023

What do these changes do?

The e2e repartition is caused by the error as follows.

 start to get ddf                                                                                                                                                                                       │
│ /usr/local/lib/python3.10/site-packages/vineyard/core/client.py:536: UserWarning: Migrating object ObjectID <"o0024772b04722d27"> from another vineyard instance 18446744073709551615                  │
│   warnings.warn(                                                                                                                                                                                       │
│ Traceback (most recent call last):                                                                                                                                                                     │
│   File "/job.py", line 55, in <module>                                                                                                                                                                 │
│     data = client.get(vineyard.ObjectID(gid),                                                                                                                                                          │
│   File "/usr/local/lib/python3.10/site-packages/vineyard/core/client.py", line 582, in get                                                                                                             │
│     return get(self, object_id, name, resolver, fetch, **kwargs)                                                                                                                                       │
│   File "/usr/local/lib/python3.10/site-packages/vineyard/core/resolver.py", line 235, in get                                                                                                           │
│     obj = client.get_object(object_id)                                                                                                                                                                 │
│   File "/usr/local/lib/python3.10/site-packages/vineyard/core/client.py", line 451, in get_object                                                                                                      │
│     return self._fetch_object(object_id)                                                                                                                                                               │
│   File "/usr/local/lib/python3.10/site-packages/vineyard/core/client.py", line 540, in _fetch_object                                                                                                   │
│     return self._ipc_client.get_object(object_id, fetch=True)                                                                                                                                          │
│ vineyard._C.InvalidException: Invalid: IPC error at /work/v6d/src/common/util/protocols.cc:2072: global objects cannot be directly migrated 

Add a juadgement before fetching object to fix that.

Related issue number

Fixes #1679

@dashanji dashanji force-pushed the fix-dask-repartition-and-unit-test-ci branch 2 times, most recently from 4a597e8 to 155b6de Compare December 29, 2023 04:06
@dashanji dashanji force-pushed the fix-dask-repartition-and-unit-test-ci branch from 155b6de to bf686bf Compare December 29, 2023 05:51
@sighingnow sighingnow changed the title Fix the unit test error and add a juadgement for fetching object Fix the unit test error and adjust the condition for fetching objects Dec 29, 2023
@sighingnow sighingnow merged commit 818ad3b into v6d-io:main Dec 29, 2023
23 checks passed
@sighingnow sighingnow deleted the fix-dask-repartition-and-unit-test-ci branch December 29, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on main in e2e-tests-sidecar and e2e-tests-repartition-dask
2 participants