Skip to content

Commit

Permalink
Fixes a missing assignment in edge id generation (#1644)
Browse files Browse the repository at this point in the history
The bug was first introduced in
1de8226#diff-f5dfc05a30caf83fbf2edde2db77177a8bf8bb8bb296b0d8259a89f566a833ff
and causes
https://github.com/alibaba/GraphScope/actions/runs/7044062862/job/19176259486?pr=3392

There's also a workaround i graphscope
(alibaba/GraphScope#3421) to fixes the CI
failure.

Signed-off-by: Tao He <[email protected]>
  • Loading branch information
sighingnow authored Dec 12, 2023
1 parent 528ca69 commit a219eae
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions modules/graph/loader/basic_ev_fragment_loader_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -739,10 +739,11 @@ BasicEVFragmentLoader<OID_T, VID_T, PARTITIONER_T>::generateEdgeId(
auto& edge_table_list = edge_tables[e_label];
uint64_t cur_id;
if (existed_elabel_id != -1) {
eid_parser.GenerateId(comm_spec.fid(), existed_elabel_id, eid_offset);
cur_id =
eid_parser.GenerateId(comm_spec.fid(), existed_elabel_id, eid_offset);
} else {
eid_parser.GenerateId(comm_spec.fid(), e_label + label_offset,
eid_offset);
cur_id = eid_parser.GenerateId(comm_spec.fid(), e_label + label_offset,
eid_offset);
}
for (size_t edge_table_index = 0;
edge_table_index != edge_table_list.size(); ++edge_table_index) {
Expand Down

0 comments on commit a219eae

Please sign in to comment.