Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog checker #4387

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Commits on Oct 21, 2021

  1. Use get-changed-files action for changelog_checker

    This action also works on merged pull requests. Before, $files_modified
    was empty on merged pull requests and the workflow failed
    agraul committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    40949fc View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Simplify changelog.rb

    Only .changes files are passed to this script by the get-changed-files
    action.
    agraul committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c3863a9 View commit details
    Browse the repository at this point in the history
  2. Use pull_request_target for changelog checker

    The automation to create comments doesn't work on the pull_request hook
    for forks due to permissions. According to the docs, the right hook to
    use is pull_request_target instead.
    
    Co-authored-by: Etheryte <[email protected]>
    agraul and Etheryte committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    7ce81cf View commit details
    Browse the repository at this point in the history