Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an end-to-end run of ResMLP (from PyTorch import to running) and compares the TVM result against the PyTorch result.
There is an additional rewrite here of linear layers. The TVM PT importer produces linear layers that look like this
whereas the FlexNLP codegen matches patterns of the form
nn.bias_add(nn.dense(*, *), *)
.Fortunately, the above is equivalent to
reshape(nn.bias_add(nn.dense(*, *), *), (1, 256, 512))
, which does match the pattern. The rewrite is currently implemented manually, but this would be a useful test case for flexible matching in the future.Please review @AD1024 -- you will have to add in the calls to our custom codegens.