Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for edit meal request modal #163

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

ColinToft
Copy link
Collaborator

@ColinToft ColinToft commented Aug 23, 2024

Notion Ticket Link

Replace with Ticket URL

Implementation Description

  • Adds validation (and red highlights if errors) on the edit meal request modal

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

Visit the preview URL for this PR (updated for commit a316bb6):

https://feeding-canadian-kids-staging--pr163-edit-meal-request-0iez1o2n.web.app

(expires Fri, 30 Aug 2024 19:36:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! So we pretty much decided both delivery instructions and dietary restrictions is not required? (followed up in slack)

@shahanneda shahanneda merged commit 4744ac8 into main Aug 24, 2024
4 checks passed
@shahanneda shahanneda deleted the edit-meal-request-validation branch August 24, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants