Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create/update payments tables #62

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

create/update payments tables #62

wants to merge 13 commits into from

Conversation

benyebai
Copy link
Collaborator

Notion ticket link

define payments endpoints](https://www.notion.so/uwblueprintexecs/define-payments-endpoints-624bfc7dd2aa4c0d9c7e9e2cc6dd7567?pvs=4)

Implementation description

  • we added update and creation endpoints

Steps to test

  1. Use postman or some sort, and test if the payment tables are being created or updated

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Collaborator

@victoryqwei victoryqwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch seems to be a bit outdated and requires rebasing. Can we rebase this branch off of main and check for type errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants