-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose local web server using ngrok #43
Conversation
Adjusted docker-compose.yml to run ngrok using my personal authentication token
Great work! I tested it out with ngrok and the port forwarding works! Let me know if you guys need any help with the remaining work you mentioned (API testing, etc.). I left a few other PR comments for you guys to address. Additionally, I'll answer some of the questions/notes you left for me:
Thanks for doing that. You're right, the
Thanks for making this change too. I remember from the first work session that a good number of people had issues with their port 5000, so we can just switch to running our backend on port 5001 for convenience reasons.
In our first work session, remember we ran a linter that checked our repo for formatting, etc. (see here). Just run that linter again to ensure that your changes don't have any additional linting errors. You can ignore the existing linting errors caused by other files in the repo. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this is going to be massively helpful for some upcoming tickets!
* Integrated Ngrok Adjusted docker-compose.yml to run ngrok using my personal authentication token * add environment variable for ngrok authtoken * Add ngrok set-up instructions in README.md * updating ngrok authtoken as variable / exposing port 5001 for backend * environment variable for ngrok authtoken instead of hardcoding * typo * update readme * delete ngrok container * Delete .DS_Store * run linter ---------
* basic table and filter created w/ chakra Co-authored-by: Jordan Kok Ee Hsin <[email protected]> * expose local web server using ngrok (#43) (#45) * Integrated Ngrok Adjusted docker-compose.yml to run ngrok using my personal authentication token * add environment variable for ngrok authtoken * Add ngrok set-up instructions in README.md * updating ngrok authtoken as variable / exposing port 5001 for backend * environment variable for ngrok authtoken instead of hardcoding * typo * update readme * delete ngrok container * Delete .DS_Store * run linter --------- * basic table and filter created w/ chakra Co-authored-by: Jordan Kok Ee Hsin <[email protected]> * basic table and filter created w/ chakra Co-authored-by: Jordan Kok Ee Hsin <[email protected]> * created table and filtering using chakra * adding navbar template * installing Tailwind + updating Navbar template to be closer to Figma design + routing for Navbar (temp) * uncommenting subLabel - please note .eslintrc.js rules ignoring require-default-props, no-unused-prop-types, and react-in-jsx-scope * center navbar components + improve spacing + rename template names to don efficace specific fields * Navbar linking/routing + Updating navbar to be like Figma design * fixed navbar spacing and link color - reorganized/simplified dashboard/donations/account stack * adding comments + changing Don Efficace. text to a link to homepage * bottom border early * adding tab indicator, reformatted dashboard/donations/acc-mgmt into tabs instead of boxes * making tab indicator responsive + adding rules back to eslintr (reverting previous changes) + small touch ups to navbar + deleting tailwind config as it is unused * adding browserrouter to layout.tsx * touch up * adding linter changes * fixing merge conflicts with main based on pr comments from Matt * merge conflict changes * fixing merge conflicts * fix app.tsx routes * fix merge conflicts --------- Co-authored-by: pahu2353 <[email protected]> Co-authored-by: Jordan Kok Ee Hsin <[email protected]>
Notion Ticket Link:
https://www.notion.so/uwblueprintexecs/e2d9163a2f8c436bbb36172066753d40?v=9518aa1af04b4478b3d5e840f4ffcc7f&p=850e4246e7d74065826f1de8203d5457&pm=s
Summary:
Expected result:
Ongoing/Incomplete:
Questions/Notes for Matt:
Checklist