Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README #35

Merged
merged 3 commits into from
May 21, 2024
Merged

Updated README #35

merged 3 commits into from
May 21, 2024

Conversation

Ee-Hsin
Copy link
Collaborator

@Ee-Hsin Ee-Hsin commented May 21, 2024

Notion ticket link

onboarding + add your name to readme

Implementation description

  • Updated README with my name

Steps to test

  1. Check my name is spelled correctly

What should reviewers focus on?

  • How cool my name is

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Ee-Hsin Ee-Hsin requested a review from mat-ng May 21, 2024 02:07
@mat-ng mat-ng merged commit 734a7a4 into onboarding May 21, 2024
@mat-ng mat-ng deleted the jordanUpdateReadMe branch May 21, 2024 04:33
mat-ng added a commit that referenced this pull request Jun 5, 2024
* Updated README w/ Patrick Huang in place of Dev 6 (#32)

* Update README.md

* Update README.md w/ Patrick Huang

Removed Dev 6.

---------

Co-authored-by: Matthew Ng <[email protected]>

* Updated README - replaced dev 3 with Jason Le (#33)

* Update README.md

* updated README - replaced dev 3 with Jason Le

---------

Co-authored-by: Matthew Ng <[email protected]>
Co-authored-by: Jason Le <[email protected]>

* changed name (#34)

* Update README.md

* changed read me ben

---------

Co-authored-by: Matthew Ng <[email protected]>
Co-authored-by: Benjamin bai <[email protected]>

* Updated README (#35)

* Update README.md

* Updated README with Jordan Kok

---------

Co-authored-by: Matthew Ng <[email protected]>

* Update READMME Dev 5 -> Leo Zhang (#36)

Co-authored-by: Matthew Ng <[email protected]>

* update Dockerfile

* Update README.md (#39)

Update README.md to replace Dev 1 with Aayush Patel

* Update README Dev 7 -> Rosanne Zhu (#38)

* Update README.md

* Update Dockerfile with MacOS change

* update README: Dev 7 -> Rosanne Zhu

---------

Co-authored-by: Matthew Ng <[email protected]>

* update readme (#41)

---------

Co-authored-by: Patrick Huang <[email protected]>
Co-authored-by: Jason Le <[email protected]>
Co-authored-by: Jason Le <[email protected]>
Co-authored-by: Benjamin Bai <[email protected]>
Co-authored-by: Benjamin bai <[email protected]>
Co-authored-by: Jordan Kok Ee Hsin <[email protected]>
Co-authored-by: Leo Zhang <[email protected]>
Co-authored-by: aayushh-patell <[email protected]>
Co-authored-by: Rosanne Zhu <[email protected]>
Co-authored-by: Andy Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants