Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitation Flow #247

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Visitation Flow #247

wants to merge 25 commits into from

Conversation

rodrigotiscareno
Copy link

Notion ticket link

Visitation Flow

Implementation description

  • Created a VisitDTO Class to support incoming data from the front-end.
  • Supported data processing to the database for complete data saving.

Steps to test

  1. Front-end form values should be recorded in the database for the visitations page
  2. Data should be in the specified format.

What should reviewers focus on?

  • We made some tweaks as to how the data is entered in the front-end which may need reviewing, perhaps as a separate ticket.

Checklist

  • [ x] My PR name is descriptive and in imperative tense
  • [ x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

placeholder="Select child(ren)"
/>
>
{/* TODO: Update these options. */}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left this as a TODO because we need to retrieve the child options from an endpoint. I'd be happy to work on this as part of a smaller ticket.

Copy link

github-actions bot commented Mar 31, 2024

Visit the preview URL for this PR (updated for commit 83d3662):

https://childrens-aid-society--pr247-rt-visit-backend-rlo9ghck.web.app

(expires Sun, 18 Aug 2024 18:20:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

readOnly={readOnly}
<Select
disabled={readOnly}
as={Select}
id="guardian"
options={["Full", "Partial", "Unsupervised"]}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applied for Transportation, original values were "options={["Full", "Partial", "Unsupervised"]}". We may need to tweak these default options. For now left as generic 1,2,3 until we decide.

visit_service.create_visit(visit)
return jsonify({"message": "Visit created successfully"}), 201
except Exception as e:
return jsonify({"error": str(e)}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants