Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUT Case implementation + more Cases Context #244

Merged
merged 1 commit into from
Apr 14, 2024
Merged

PUT Case implementation + more Cases Context #244

merged 1 commit into from
Apr 14, 2024

Conversation

JennyVong
Copy link
Contributor

Notion ticket link

Link and Integrate PUT Case Submission Pt. 2

Implementation description

  • implemented put case submission API call integration for cases with status: pending, submitted, archived
  • refactored some parts of code to use IntakeValueContext and CasesContext

Steps to test

  1. click on a case with pending, submitted or archived status
  2. view dynamic values on there and see if it matches with entry in db
  3. click review and edit any of the values
  4. changes should reflect on both frontend and backend

What should reviewers focus on?

  • family name can't be changed for some reason - I can look into this in another ticket (I can make the bug ticket)
  • backend tests are failing in main - I can also look into this in another ticket if you want
  • we can sync up on this in a work session or call just lmk

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 98f7f6a):

https://childrens-aid-society--pr244-jenny-put-case-2-dmfihkew.web.app

(expires Sun, 07 Apr 2024 22:11:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

vaaranan-y
vaaranan-y reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@vaaranan-y vaaranan-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes may be needed, but after that, should be good to merge

frontend/package-lock.json Outdated Show resolved Hide resolved
frontend/src/APIClients/IntakeAPIClient.ts Outdated
cpinFileType: intake.caseReferral.cpinFileType,
familyName: intake.caseReferral.familyName,
referralDate: new Date(
intake.caseReferral.referralDate,
).toLocaleDateString("en-GB"),
},
courtInformation: {
courtStatus: intake.courtInformation.courtStatus,
orderReferral: 0,
currentCourtStatus: intake.courtInformation.courtStatus,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you chose to change the variable name from courtStatus to currentCourtStatus? Might be best to follow whatever is established in the database already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was following what was currently in CourtInformationForm but should've just changed the prop names in there instead of changing everything else to currentCourtStatus --my mistake!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks!

frontend/src/types/CasesContextTypes.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make any more changes to attribute names, just make sure to carry forward the changes here and anywhere else the variables are used (there should be a shortcut to do this in VS code I think)

@JennyVong JennyVong force-pushed the jenny/put-case-2 branch 2 times, most recently from f71cacd to efe8476 Compare March 31, 2024 22:04
vaaranan-y
vaaranan-y approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@vaaranan-y vaaranan-y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge.

@JennyVong JennyVong merged commit d66ff19 into main Apr 14, 2024
7 checks passed
@JennyVong JennyVong deleted the jenny/put-case-2 branch April 14, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaaranan-y vaaranan-y vaaranan-y approved these changes

Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JennyVong @vaaranan-y