Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation #242

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Conversation

desai-dev
Copy link

@desai-dev desai-dev commented Feb 11, 2024

Notion ticket link

Intake Form Validation(https://www.notion.so/uwblueprintexecs/134e1f159caa4f73939d11a700c325ad?v=39cf7d5a98384eb9af2bff2265d0ac8a&p=5f93e04364a84eae9330c43a24c19031&pm=s)

Implementation description

  • Used Formik validate prop to validate date in specified format (YYYY-MM-DD or DD/MM/YYYY)
  • Used state variable to keep track of error and display it, if there is an error

Steps to test

  1. Go to any Date Field in the Intake Form and type in an invalid date
Screen Shot 2024-02-11 at 1 49 50 PM
  1. There should be a message that says Invalid date. It should also update live as you type the text. For example if you have an invalid date, and then change it to make it valid, there error message should disappear right away.

What should reviewers focus on?

  1. Should we disable the "Next" button when there is an erro?
Screen Shot 2024-02-11 at 1 49 42 PM

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

Visit the preview URL for this PR (updated for commit dfc7722):

https://childrens-aid-society--pr242-form-validation-naorah79.web.app

(expires Sun, 18 Feb 2024 18:54:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

@desai-dev desai-dev changed the base branch from main to malvika/intake_form_validation February 20, 2024 00:08
@malvikapatel malvikapatel merged commit a0ebd14 into malvika/intake_form_validation Feb 20, 2024
6 of 7 checks passed
@malvikapatel malvikapatel deleted the form-validation branch February 20, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants