Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kevin y/update daytime contact model #238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Kevin y/update daytime contact model #238

wants to merge 3 commits into from
+94 −48

Conversation

kevinasian122
Copy link
Contributor

Notion ticket link

Update Daytime Contact Model

Implementation description

  • added child_id to daytime contact, and removed daytime_contact_id from child

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 14, 2023
View reviewed changes
backend/python/app/rest/intake_routes.py
undos.append((child_service, "delete_child", child_response.id))
except Exception as error:
run_undos()
return jsonify(error), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ezzhingy Ezzhingy Awaiting requested review from Ezzhingy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinasian122