Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching Python versions (Heroku build) #228

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Switching Python versions (Heroku build) #228

merged 2 commits into from
Dec 5, 2023

Conversation

Ezzhingy
Copy link
Collaborator

@Ezzhingy Ezzhingy commented Dec 5, 2023

Notion ticket link

Heroku build is failing, here is the reason:
Screenshot 2023-12-04 at 9 54 45 PM

To solve: upgrade Python versions

Implementation description

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Ezzhingy Ezzhingy merged commit c633bc8 into main Dec 5, 2023
2 checks passed
@Ezzhingy Ezzhingy deleted the eugene/test-heroku branch December 5, 2023 02:57
@Ezzhingy Ezzhingy restored the eugene/test-heroku branch December 5, 2023 03:09
Ezzhingy added a commit that referenced this pull request Dec 5, 2023
@Ezzhingy
Revert "Switching Python versions (Heroku build) (#228)"
2fbc168 
This reverts commit c633bc8.
@Ezzhingy Ezzhingy deleted the eugene/test-heroku branch December 5, 2023 03:10
@Ezzhingy Ezzhingy restored the eugene/test-heroku branch December 5, 2023 03:11
@Ezzhingy Ezzhingy deleted the eugene/test-heroku branch December 5, 2023 03:11
@Ezzhingy Ezzhingy mentioned this pull request Dec 5, 2023
Merged
jacque1ine pushed a commit that referenced this pull request Dec 11, 2023
@Ezzhingy @jacque1ine
Switching Python versions (Heroku build) (#228)
0361a59 
Switching versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ezzhingy