Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attendance record model #225

Merged
merged 13 commits into from
Dec 12, 2023
Merged

Update attendance record model #225

merged 13 commits into from
Dec 12, 2023

Conversation

cindyhjli
Copy link
Contributor

@cindyhjli cindyhjli commented Nov 21, 2023

Notion ticket link

Ticket Name

Implementation description

  • Updated attendance record model to match schema

Steps to test

  1. Run db_seed.py

What should reviewers focus on?

  • error handling in attendance_records_dto.py

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@cindyhjli cindyhjli marked this pull request as draft November 21, 2023 03:11
@cindyhjli cindyhjli changed the title updated attendance record model Update attendance record model Dec 5, 2023
@cindyhjli cindyhjli marked this pull request as ready for review December 7, 2023 06:26
Copy link
Collaborator

@Ezzhingy Ezzhingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmlgtm ship it 🚢

@Ezzhingy Ezzhingy self-requested a review December 12, 2023 03:01
@cindyhjli cindyhjli merged commit 3eaeaf0 into main Dec 12, 2023
5 checks passed
@cindyhjli cindyhjli deleted the cindy/attendance_records branch December 12, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants