Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra field in db_seed #206

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add extra field in db_seed #206

merged 1 commit into from
Sep 21, 2023

Conversation

Ezzhingy
Copy link
Collaborator

@Ezzhingy Ezzhingy commented Sep 9, 2023

Notion ticket link

Implementation description

  • Fix seeding data into database

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

bowenzhu1
bowenzhu1 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@bowenzhu1 bowenzhu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sending my regards

@Ezzhingy Ezzhingy merged commit c5673fa into main Sep 21, 2023
5 checks passed
@Ezzhingy Ezzhingy deleted the eugene/add-field-db-seed branch September 21, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenzhu1 bowenzhu1 bowenzhu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ezzhingy @bowenzhu1