Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nits in avl.rs #95

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

nits in avl.rs #95

wants to merge 6 commits into from

Conversation

madelinegordon
Copy link

@madelinegordon madelinegordon commented Dec 27, 2024 •
edited
Loading

nits:

  • In types.rs, added / for consistency so the comment would appear in doc comments
  • In avl.rs, renamed get_balance to get_balance_factor and added comments for clarity; renamed update to update_height_and_size for clarity

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Dec 27, 2024 •
edited
Loading

Here's the code health analysis summary for commits 7a42bf7..f989f39. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@madelinegordon madelinegordon changed the title nits and small AVL refactor nits Dec 27, 2024
@madelinegordon madelinegordon changed the title nits nits in avl.rs Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsetiawan lsetiawan Awaiting requested review from lsetiawan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madelinegordon